StringUtils.cleanPath should not strip off the entire path for `file:./` [SPR-16908]

[spring-projects-issues]

Madhura Bhave opened SPR-16908 and commented

StringUtils.cleanPath("file:../") returns file:../ and it doesn't seem right that StringUtils.cleanPath("file:./") returns file:

---

Affects: 5.0.6

Reference URL: spring-projects/spring-boot#13147

Referenced from: commits d3b06a1, 7a02e43

0 votes, 5 watchers

[spring-projects-issues]

Stéphane Nicoll commented

We're affected by that issue with Spring Framework 5.0.x. It's unfortunately too late to get a fix now but would you consider backporting the fix in the next 5.0.x maintenance release?

[spring-projects-issues]

Juergen Hoeller commented

Generally happy to do a 5.0.x backport here... However, it's not quite trivial to address this in the first place, even for 5.1. Algorithmically an empty path is the correct result in such a case, it's just that such an empty path isn't really usable in practice for certain purposes.

[spring-projects-issues]

Juergen Hoeller commented

Madhura Bhave, could you provide some context here please? How do you arrive at "file:./" in the first place, and where specifically are you passing it in? Could you work around it in Boot for the time being so that a revision here isn't as urgent?

[spring-projects-issues]

Madhura Bhave commented

This is the original issue spring-projects/spring-boot#13147. I suppose we could do something in Boot that supports "[file:./"|file:///] in this case if the backport to 5.0.x isn't straightforward.

[spring-projects-issues]

Juergen Hoeller commented

This is in master now, as a check at the end of the algorithm whether we're effectively left with an empty path after collapsing a specified directory path to begin with. I'll backport this to 5.0.8 ASAP.

[spring-projects-issues]

Juergen Hoeller commented

Madhura Bhave, does this work for Boot's purposes now, also against 5.0.8?

[spring-projects-issues]

Madhura Bhave commented

Yes, this works for us. Thank you!