Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Marius Rubin opened SPR-17144 and commented
In scenarios where a call to a WebFlux application using ContextPathCompositeHandler do not match against a context path then the response can still be status code 200, rather than 404.
It looks like this is because the ContextPathCompositeHandler calls response.setComplete() but returns Mono.empty() when no handlers for a given path have been found.
This results in the callback chain for response.setComplete(), including the commit, and applyStatusCode() invocation to be discarded.
As a result, while the response status has been set to 404, this is not what gets written to outbound buffer.
This project: https://github.com/maubergine/cpch-bug-example illustrates the issue and the effect of updating the code (PR to be raised shortly).
Affects: 5.0.8, 5.1 RC1
Referenced from: pull request #1921
The text was updated successfully, but these errors were encountered:
Marius Rubin commented
PR created: #1921
Sorry, something went wrong.
Rossen Stoyanchev commented
This should be fixed now. Thanks for the analysis and repro project!
No branches or pull requests