Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid argument resolution overhead for no-arg factory methods [SPR-17171] #21707

Closed
spring-projects-issues opened this issue Aug 13, 2018 · 1 comment
Closed

Avoid argument resolution overhead for no-arg factory methods [SPR-17171] #21707

spring-projects-issues opened this issue Aug 13, 2018 · 1 comment
Assignees
@jhoeller
Labels
in: core type: enhancement
Milestone
5.1 RC2

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Aug 13, 2018

Juergen Hoeller opened SPR-17171 and commented

ConstructorResolver's argument resolution around createArgumentArray is effectively bypassed for no-arg constructors but not for no-arg factory methods. Let's streamline this towards a straight invocation of the factory method itself in such a scenario.

Affects: 5.1 RC1

Referenced from: commits 347852e
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Aug 13, 2018

Juergen Hoeller commented

I've also aligned constructor argument resolution the same way, even if this just applies in specific scenarios since we usually bypass it upfront.

@spring-projects-issues spring-projects-issues added type: enhancement in: core labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 5.1 RC2 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: core type: enhancement
Projects
None yet
Milestone
5.1 RC2
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues