LogFormatUtils.formatValue does not leniently handle toString() exceptions [SPR-17397]

[spring-projects-issues]

Hans opened SPR-17397 and commented

Steps to reproduce:

1. create two entities with a JPA-one-to-many-relationship between the two
2. annotate both classes with lombok's @Data (generating e.g. toString())
3. set logging.level.org.springframework.web to DEBUG
4. POST a new child object with a parent reference
5. Spot the exception. In my case, backend state was correct, frontend stopped working.

Lombok's autogenerated toString() methods probably result in an endless loop in this call:

spring-framework/spring-core/src/main/java/org/springframework/core/log/LogFormatUtils.java

Line 50 in fdaceeb

String s = (value instanceof CharSequence ? "\"" + value + "\"" : value.toString());

Besides excluding some fields from being toStringified() by lombok, this method probably shouldn't throw an error in any case so you might consider try-catching the call.

---

Affects: 5.1.1

Referenced from: commits 7ff938b

[spring-projects-issues]

Juergen Hoeller commented

We defensively catch any exception there now, logging the toString() representation of the exception instead in that case (similar to how an IDE does it in the debugger).

[spring-projects-issues]

Hans commented

Thanks a lot to Juergen Hoeller for the instant fix (fix as in: as long as Throwable.toString() won't throw itself)!