Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow java.time types for setting the Last-Modified header [SPR-17571] #22103

Closed
spring-issuemaster opened this issue Dec 6, 2018 · 0 comments
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 6, 2018

Lars Grefer opened SPR-17571 and commented

org.springframework.http.ResponseEntity.HeadersBuilder.lastModified and org.springframework.http.HttpHeaders.setLastModified only accept the date as long.

This long value is then internally converted to a java.time.Instant and a java.time.ZonedDateTime.

I propose to add overloads for the methods listed above which directly accept the "new" java.time types.


Affects: 5.1.3

Issue Links:

  • #19441 TaskScheduler interface should support java.time.Instant/Duration
  • #21104 Overloaded convenience setters on HttpHeaders
  • #20220 Consider using ZonedDateTime in HttpHeaders
  • #22120 Consistent handling of null header values in HttpHeaders

Referenced from: pull request #2039, and commits a240cfc, 9abd4ed, 6a01214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.