Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid creation of unused logger instance in AbstractMediaTypeExpression #25901

Closed
jhoeller opened this issue Oct 12, 2020 · 0 comments
Closed

Avoid creation of unused logger instance in AbstractMediaTypeExpression #25901

jhoeller opened this issue Oct 12, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.10

Comments

@jhoeller
Copy link
Contributor

As revealed by #25900, the logger instance in AbstractMediaTypeExpression is entirely unused. Since this is a non-public internal base class in both MVC and WebFlux, we can drop the unused logger field completely even in the backport branches.
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 12, 2020
@jhoeller jhoeller added this to the 5.2.10 milestone Oct 12, 2020
@jhoeller jhoeller self-assigned this Oct 12, 2020
@jhoeller jhoeller added the for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x label Oct 12, 2020
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x Marks an issue as a candidate for backport to 5.1.x labels Oct 12, 2020
Closed
Closed
Closed
jhoeller added a commit that referenced this issue Oct 12, 2020
@jhoeller
Avoid creation of unused logger instance in AbstractMediaTypeExpression
25a1bfb 
Closes gh-25901
jhoeller added a commit that referenced this issue Oct 12, 2020
@jhoeller
Avoid creation of unused logger instance in AbstractMediaTypeExpression
f355b17 
Closes gh-25901
jhoeller added a commit that referenced this issue Oct 12, 2020
@jhoeller
Avoid creation of unused logger instance in AbstractMediaTypeExpression
678ea4e 
Closes gh-25901
zx20110729 pushed a commit to zx20110729/spring-framework that referenced this issue Feb 18, 2022
@jhoeller @zx20110729
Avoid creation of unused logger instance in AbstractMediaTypeExpression
c4804f1 
Closes spring-projectsgh-25901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.10
Development

No branches or pull requests
2 participants
@jhoeller @spring-projects-issues