Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITS: SEARCH IGNORES TICKETS TRACKING OUTSTANDING ISSUES BY DEFAULT #27532

Closed
Chealer opened this issue Oct 7, 2021 · 2 comments
Closed

ITS: SEARCH IGNORES TICKETS TRACKING OUTSTANDING ISSUES BY DEFAULT #27532

Chealer opened this issue Oct 7, 2021 · 2 comments
Labels
status: declined A suggestion or change that we don't feel we should currently apply status: duplicate A duplicate of another issue

Comments

@Chealer
Copy link

Chealer commented Oct 7, 2021

Affects: N/A


Some of Spring's issue tracking has recently moved from Spring's Jira instance to GitHub. I'm afraid this brought a grave issue with search, which affects at least Spring Data JPA ticket #2085 and Spring Data Commons ticket #2458. One way to reproduce would be to go to the issue tracker of an affected project and add to the search query a word part of a closed ticket's title, then launch search (press Enter). For example, on Spring Data JPA's tracker, add "hints" to the text field. You will get a result like the following:
image

This lacks ticket #2085, even if it has that term right in the title:

5.3.9. Applying Query Hints unclear about JPA query hints [DATAJPA-1790]

This false negative is in fact caused by a default search criteria which can be seen in the input field's default value:

is:issue is:open

"is:open" excludes closed tickets.

Unless this is the result of a misconfiguration which can be fixed simply, I would recommend at least halting migration.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 7, 2021
@bclozel
Copy link
Member

bclozel commented Oct 8, 2021

Hello @Chealer

Unless this is the result of a misconfiguration which can be fixed simply, I would recommend at least halting migration.

As far as I know, there's no configuration for that. For consistency with the plethora of OSS projects hosted on GitHub, we'd rather stick to GitHub's default and not confuse the community.

The migration has finished over two years ago, so GitHub issues has been the new normal for quite a while and well received by the vast majority of the community. You can learn more about GitHub issue here; it might take a bit of time to adjust but the search capability is quite powerful.

It looks like this has been discussed already in spring-projects/spring-data-commons#2458, so I'm closing this issue now.

@bclozel bclozel closed this as completed Oct 8, 2021
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 8, 2021
@spring-projects spring-projects locked as resolved and limited conversation to collaborators Oct 8, 2021
@snicoll snicoll added the status: duplicate A duplicate of another issue label Oct 8, 2021
@rstoyanchev
Copy link
Contributor

This false negative is in fact caused by a default search criteria which can be seen in the input field's default value:

is:issue is:open

"is:open" excludes closed tickets.

Wouldn't you just click on Open or Closed, and/or change any other filter for that matter? That's just part of applying the knobs and levers of the search screen. I don't see anything ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: declined A suggestion or change that we don't feel we should currently apply status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

5 participants