Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a constructor with externally managed Reactor Netty resources to ReactorNettyClientRequestFactory #31280

Closed
sdeleuze opened this issue Sep 20, 2023 · 0 comments
Closed

Add a constructor with externally managed Reactor Netty resources to ReactorNettyClientRequestFactory #31280

sdeleuze opened this issue Sep 20, 2023 · 0 comments
Assignees
@sdeleuze
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.1.0-RC1

Comments

@sdeleuze
Copy link
Contributor

sdeleuze commented Sep 20, 2023 •
edited

In order to support CRaC and Spring lifecycle, ReactorNettyClientRequestFactory implementation should provide a constructor to allow proper recreation of the underlying http client after a restart with related resource management.
@sdeleuze sdeleuze added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Sep 20, 2023
@sdeleuze sdeleuze added this to the 6.1.0-RC1 milestone Sep 20, 2023
@sdeleuze sdeleuze self-assigned this Sep 20, 2023
@sdeleuze sdeleuze changed the title Add a Supplier based constructor to ClientHttpRequestFactory implementations Add a Supplier based constructor to ReactorNettyClientRequestFactory Oct 10, 2023
@sdeleuze sdeleuze changed the title Add a Supplier based constructor to ReactorNettyClientRequestFactory Add a constructor with externally managed Reactor Netty resources to ReactorNettyClientRequestFactory Oct 10, 2023
@sdeleuze sdeleuze mentioned this issue Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-RC1
Development

No branches or pull requests
1 participant
@sdeleuze