SimpleNamingContextBuilder never sets the activated SimpleNamingContextBuilder in emptyActivatedContextBuilder() [SPR-1376]

[spring-projects-issues]

Daniel Fröding opened SPR-1376 and commented

The static variable
private static SimpleNamingContextBuilder activated;
Is never set in the else clause in following method.

   public static SimpleNamingContextBuilder emptyActivatedContextBuilder() throws NamingException {
	if (activated != null) {
		// clear already activated context builder
		activated.clear();
		return activated;
	}
	else {
		// create and activate new context builder
		SimpleNamingContextBuilder builder = new SimpleNamingContextBuilder();
		builder.activate();
		return builder;
	}
}

This will eventually result in a "java.lang.IllegalStateException: InitialContextFactoryBuilder already set" exception when serveral tests are run within the same JVM.

---

Affects: 1.2.5

[spring-projects-issues]

Juergen Hoeller commented

Actually, the "activated" variable is set: in SimpleNamingContextBuilder's "activate()" implementation. This will kick in for an "emptyActivatedContextBuilder()" call as well as for direct SimpleNamingContextBuilder instantiation with a subsequent "activate()" call. I've added a comment that points out that assignment process.

Juergen