TransactionSynchronizationUtils.triggerBeforeCompletion() is swallowing IllegalStateException [SPR-2883]

[spring-projects-issues]

Josh Moore opened SPR-2883 and commented

If the synchronization throws an exception on beforeCompletion() then things get quirky. Specifically, SpringSessionSynchronization.beforeCompletion() has this block:
if (this.newSession) {
// Default behavior: unbind and close the thread-bound Hibernate Session.
TransactionSynchronizationManager.unbindResource(this.sessionFactory); // THROWS HERE
this.holderActive = false;
if (this.hibernateTransactionCompletion) {
// Close the Hibernate Session here in case of a Hibernate TransactionManagerLookup:
// Hibernate will automatically defer the actual closing until JTA transaction completion.
// Else, the Session will be closed in the afterCompletion method, to provide the
// correct transaction status for releasing the Session's cache locks.
SessionFactoryUtils.closeSessionOrRegisterDeferredClose(this.sessionHolder.getSession(), this.sessionFactory);
}
}

My code is causing an IllegalStateException on unbindResource() (working to find out what's causing that), which gets logged in TransactionSynchronizationUtils (below) but doesn't throw:

  public static void triggerBeforeCompletion() {
	for (Iterator it = TransactionSynchronizationManager.getSynchronizations().iterator(); it.hasNext();) {
		TransactionSynchronization synchronization = (TransactionSynchronization) it.next();
		try {
			synchronization.beforeCompletion();
		}
		catch (Throwable tsex) {
			logger.error("TransactionSynchronization.beforeCompletion threw exception", tsex);
		}
	}
}

Since the registering of close in SpringSessionSynchronization isn't getting called, the transaction isn't getting committed, which means...

I'm getting return values (entity with id = k) but there's no entity with primary key k in the db. Weirdness.

Thanks, guys.
Josh.

---

Affects: 2.0 final

[spring-projects-issues]

Josh Moore commented

#6959 seems to be related.

[spring-projects-issues]

Juergen Hoeller commented

We do need to catch and log the exception there, since the beforeCompletion needs to be continued with all other registered synchronizations. This is also documented in TransactionSynchronization's javadoc.

However, unbindResource throwing an IllegalStateException is pretty bad. Are you using transaction suspension (PROPAGATION_REQUIRES_NEW)? We had a bug there that has been fixed in 2.0.1. So in that case, please give 2.0.1 a try and check whether your scenario still fails...

Juergen

[spring-projects-issues]

Josh Moore commented

Updated; no change. And no transaction suspension (i.e. all defaults @Transactional(readOnly=false)).

Sorry that I missed the TransactionSynchronization doc. I fear it's something far more complicated: in order to support ExtendedPersistentContext-LIKE stateful services, I'm directly invoking some of Spring's transaction synchronization infrastructure. This is, however, on a different service in a different thread. Since the exception needs to be eaten, I'll just have to guarantee that my threads are clean. (At least until I can rework with true EPC.)

Thanks, Juergen.
Josh.

[spring-projects-issues]

Juergen Hoeller commented

OK... I'm afraid we won't be able to do anything about the exception catching-and-logging there.

Good luck with the ExtendedPersistenceContext-like solution... This certainly won't be trivial. It's a good thing that JPA finally introduced dedicated support for extended contexts, even if it's still up to the application to manage the lifecycle of such an extended context.

Juergen