PersistenceAnnotationBeanPostProcessor fails to find EMFBs [SPR-3434]

[spring-projects-issues]

Barry Kaplan opened SPR-3434 and commented

The changes from 2.0.3 to 2.0.4 has cause some side effects. In 2.0.3 the PABPP would use beanFactory.getBean(..) to obtain the EMFs. In 2.0.4 it first beanFactory.isTypeMatch(..)

When the EMF has not yet been created in the context, AbstractEntityMangagerFactoryBean.getObjectType will return EntityManagerFactory.class, but PABPP compares the class against EntityManagerFactoryInfo.class. Hence due the abitrary ordering of bean creation most of my EMFs fail to be discovered by the PABPP.

PABPP.findNamedEntityManagerFactory(..) returns EntityManagerFactory (not EMFInfo), so why does it check for the EMFInfo.class?

I cannot simply have PABPP depend on the LCEMFBs because it defined in a generic config file, where the LCEMFBs are defined in component specific config files.

---

Affects: 2.0.4

Issue Links:

• PersistenceAnnotationBeanPostProcessor fails to match unitName of lazy loaded EMFs in some cases [SPR-3370] #8054 PersistenceAnnotationBeanPostProcessor fails to match unitName of lazy loaded EMFs in some cases ("duplicates")

[spring-projects-issues]

Barry Kaplan commented

I've been debugging this for some time. I can't see how PersistenceAnnotationBeanPostProcessor could ever work with an AbstractEntityMangagerFactoryBean unless that target bean has already been created. In the case where the post-processer is triggered by the creation of an bean injected using @EntityManager and the factory bean has not yet created its instance, the post-process fails due to its checking whether the instance AbstractEntityMangagerFactoryBean creates is an EntityManagerFactoryInfo (which is always false for AbstractEntityMangagerFactoryBean as far as I can tell).

[spring-projects-issues]

Barry Kaplan commented

Here's the hack I had to do get my application working again:

---

// TP_HACK This method is become very broke somewhere between 2.0.1 and 2.0.4.
// See http://opensource.atlassian.com/projects/spring/browse/SPR-3434
protected EntityManagerFactory findNamedEntityManagerFactory(String unitName) throws NoSuchBeanDefinitionException {
    // See whether we can find an EntityManagerFactory with matching persistence unit name.
    String[] candidateNames =
            BeanFactoryUtils.beanNamesForTypeIncludingAncestors(this.beanFactory, EntityManagerFactory.class);
    for (String candidateName : candidateNames) {
        // TP_HACK This if-statment is the problem. It will go thru lots of pain to try to determine
        // the class that the factory creates. But in the case of AbstractEntityManagerFactory,
        // the factory itself implements EntityManagerFactoryInfo; the instance the factory
        // creates does not. In any case, generally at this point the instance has not even
        // yet been created. 
        // So, we comment out this next line and throw an exception if the emf is not 
        // not found by name.

// if (this.beanFactory.isTypeMatch(candidateName, EntityManagerFactoryInfo.class)) {
EntityManagerFactoryInfo emfi = (EntityManagerFactoryInfo) this.beanFactory.getBean(candidateName);
if (emfi == null) {
throw new RuntimeException("Could not find EntityManagerFactory with bean name '" + candidateName + ";");
}
if (unitName.equals(emfi.getPersistenceUnitName())) {
return (EntityManagerFactory) emfi;
// }
}
}
// No matching persistence unit found - simply take the EntityManagerFactory
// with the persistence unit name as bean name (by convention).
return (EntityManagerFactory) this.beanFactory.getBean(unitName);
}

---

[spring-projects-issues]

Juergen Hoeller commented

This has already been discovered and fixed a couple of days ago, fortunately.

Please try a recent Spring 2.0.5 snapshot (http://www.springframework.org/snapshots) and let us know whether it works for you...

Juergen

[spring-projects-issues]

Barry Kaplan commented

2.0.5-SNAPSHOT indeed corrects this problem. Thanks!