HibernateTemplate does not consistently detect pre-bound Session when using a custom SessionFactory proxy [SPR-5033]

[spring-projects-issues]

Stefan Schmidt opened SPR-5033 and commented

This issue is a side effect of #8051.

HibernateTemplate should detect a HibernateTransactionManager-driven transaction where the transactional Session is obtained through a custom SessionFactory proxy.

In the JTA case, there are no guarantees that openSession() will be called through the proxy in the first place since Hibernate's own JTA support uses internal calls on the SessionFactory there.

However, Hibernate's own CurrentSessionContext implementations will keep using the native SessionFactory object directly. Native sessionFactory.getCurrentSession() calls will always bypass the custom
SessionFactory proxy's openSession() method. The custom proxy needs to intercept and handle getCurrentSession() calls accordingly as well.

---

Affects: 2.5.5

Issue Links:

• HibernateTemplate doesn't work with Transactions externally managed behind hibernates getCurrentSession() [SPR-3367] #8051 HibernateTemplate doesn't work with Transactions externally managed behind hibernates getCurrentSession()

[spring-projects-issues]

Stefan Schmidt commented

Maybe the subject line should be updated to: "Spring Hibernate integration unable to handle user-wrapped SessionFactory"

The fundamental issue is that if the user does their own wrapping of the sessionfactory after they get it, they can not reliably use that wrapped sessionfactory as spring is still referring to the unwrapped one in some cases.

[spring-projects-issues]

Juergen Hoeller commented

After some further research, there does not seem to be a way to make this work consistenly for the "SessionFactory.getCurrentSession()" method. Not only our SpringSessionContext keeps hold on to the raw SessionFactory object; all of the Hibernate-provided CurrentSessionContext implementations do the same! It's part of the CurrentSessionContext contract to operate on the raw SessionFactory as passed in through the constructor...

So from that perspective, SessionFactory proxies that expect to go through some special code for Session creation need to intercept not only "openSession()" but also "getCurrentSession()", at least if the latter method is actually used in the application. However, for HibernateTemplate purposes, intercepting "openSession()" should be sufficient, provided that transaction management operates with pre-bound Sessions (like HibernateTransactionManager does, or JtaTransactionManager with a HibernateInterceptor). I've restored that latter behavior for Spring 2.5.6, in order to match the well-known semantics of Spring 1.2/2.0 again.

This will be available in tonight's 2.5.6 snapshot (http://static.springframework.org/downloads/nightly/snapshot-download.php?project=SPR). Please give it a try and let me know whether it works for you...

Juergen

[spring-projects-issues]

Stéphane Nicoll commented

Well I am using 2.5.6 and it seems that I have this issue. I have a remote service with a TransactionalProxyFactoryBean to handle the order of interceptors within a transaction. This remote service calls a persistenceservice bean that uses HibernateTemplate and @Transactional annotations.

With this setup and 2.5.6 I got the following exception

org.springframework.transaction.IllegalTransactionStateException : 
Pre-bound JDBC Connection found! HibernateTransactionManager does not support running within DataSourceTransactionManager if told to manage the DataSource itself. 
It is recommended to use a single HibernateTransactionManager for all transactions on a single DataSource, no matter whether Hibernate or JDBC access.

See also http://forum.springsource.org/showthread.php?p=226974#post226974