Polishing regarding JDK baseline upgrade #28440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aooohan Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@aooohan Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: task
sbrannen
requested changes
May 10, 2022
...main/java/org/springframework/aop/aspectj/autoproxy/AspectJAwareAdvisorAutoProxyCreator.java
Outdated
Show resolved
Hide resolved
spring-aop/src/main/java/org/springframework/aop/framework/ProxyFactoryBean.java
Outdated
Show resolved
Hide resolved
spring-aop/src/main/java/org/springframework/aop/support/AbstractPointcutAdvisor.java
Outdated
Show resolved
Hide resolved
spring-beans/src/main/java/org/springframework/beans/AbstractNestablePropertyAccessor.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java
Outdated
Show resolved
Hide resolved
...java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapter.java
Outdated
Show resolved
Hide resolved
sbrannen
added
the
status: waiting-for-feedback
…actPointcutAdvisor.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
…roxy/AspectJAwareAdvisorAutoProxyCreator.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
…xyFactoryBean.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
…establePropertyAccessor.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
…c/method/annotation/RequestMappingHandlerAdapter.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
…c/method/annotation/RequestMappingHandlerAdapter.java Co-authored-by: Sam Brannen <sbrannen@vmware.com>
|
@sbrannen I have updated it.Thank you for reviewing my pr |
sbrannen
requested changes
May 10, 2022
spring-web/src/main/java/org/springframework/http/HttpMethod.java
Outdated
Show resolved
Hide resolved
spring-projects-issues
added
status: feedback-provided
sbrannen
approved these changes
May 10, 2022
sbrannen
reviewed
May 10, 2022
| @@ -366,7 +366,7 @@ private void enlarge(final int size) { | |||
| } | |||
| int doubleCapacity = 2 * data.length; | |||
| int minimalCapacity = length + size; | |||
| byte[] newData = new byte[doubleCapacity > minimalCapacity ? doubleCapacity : minimalCapacity]; | |||
| byte[] newData = new byte[Math.max(doubleCapacity, minimalCapacity)]; | |||
There was a problem hiding this comment.
I noticed while merging that this is our repackaged ASM code.
Here's our policy:
Please refrain from modifying classes under
org.springframework.asm,org.springframework.cglib, andorg.springframework.objenesis. Those include repackaged forks of the third-party libraries ASM, CGLIB, and Objenesis. Any refactoring to those classes should take place upstream in the originating repository. The Spring Framework will then pick up the changes when syncing with official updates of the forked third-party libraries.
So I'll revert that change locally.
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.