Skip to content

Minor fixes in spring-websocket #29408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Minor fixes in spring-websocket #29408

wants to merge 6 commits into from

Conversation

imkulwant
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 31, 2022
@imkulwant imkulwant closed this Oct 31, 2022
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 1, 2022
@sbrannen
Copy link
Member

sbrannen commented Nov 1, 2022 •
edited
Loading

Hi @imkulwant,

Thanks for creating your first PR for the Spring Framework.

Aside from some Checkstyle violations and unnecessary Javadoc changes (which I can address for you), I think this PR seems reasonable.

So, would you mind if we reopen and merge this PR?

@imkulwant
Copy link
Contributor Author

Hi @imkulwant,

Thanks for creating your first PR for the Spring Framework.

Aside from some Checkstyle violations and unnecessary Javadoc changes (which I can address for you), I think this PR seems reasonable.

So, would you mind if we reopen and merge this PR?

Hi @sbrannen

I had closed the PR to fix some test failures. Will fix them and re-open again.

@imkulwant imkulwant reopened this Nov 1, 2022
@sbrannen sbrannen self-assigned this Nov 2, 2022
@sbrannen sbrannen added type: task A general task and removed status: declined A suggestion or change that we don't feel we should currently apply labels Nov 2, 2022
@sbrannen sbrannen added this to the 6.0.0-RC3 milestone Nov 2, 2022
sbrannen pushed a commit that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Use StandardCharsets
bd57d86 
See gh-29408
sbrannen pushed a commit that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Remove unnecessary calls to toString()
19955c5 
See gh-29408
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Replace concatenated strings with text blocks
eec3c6f 
See spring-projectsgh-29408
sbrannen pushed a commit that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Use List.of() instead of Arrays.asList() where appropriate
5f2a6fd 
See gh-29408
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Fix Javadoc links
20d0bec 
See spring-projectsgh-29408
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Nov 2, 2022
@imkulwant @sbrannen
Fix tests and checkstyle violations
5245327 
See spring-projectsgh-29408
sbrannen added a commit that referenced this pull request Nov 2, 2022
@sbrannen
Polishing
723e09c 
See gh-29408
@sbrannen
Copy link
Member

sbrannen commented Nov 2, 2022

These commits have been merged into main and revised in 723e09c.

Thanks

@sbrannen sbrannen closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
type: task A general task
Projects
None yet
Milestone
6.0.0-RC3
Development

Successfully merging this pull request may close these issues.
4 participants
@imkulwant @sbrannen @bclozel @spring-projects-issues