Skip to content

Conversation

Aashay-Chapatwala
Copy link
Contributor

Adding title tag for Accessibility compliance issue

@pivotal-cla
Copy link

@Aashay-Chapatwala Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 28, 2022
@pivotal-cla
Copy link

@Aashay-Chapatwala Thank you for signing the Contributor License Agreement!

@sbrannen sbrannen added the in: web Issues in web modules (web, webmvc, webflux, websocket) label Nov 28, 2022
@sbrannen sbrannen self-assigned this Nov 28, 2022
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Nov 28, 2022
@sbrannen sbrannen changed the title Update Title in SocketJS iFrame for compliance Add title to SocketJS iFrames for accessibility compliance Nov 28, 2022
@sbrannen sbrannen modified the milestones: 5.3.25, 6.0.3 Nov 28, 2022
@sbrannen
Copy link
Member

sbrannen commented Nov 28, 2022

Hi @Aashay-Chapatwala,

Congratulations on submitting your first PR for the Spring Framework! 👍

@sbrannen sbrannen changed the title Add title to SocketJS iFrames for accessibility compliance Add title to SockJS iFrames for accessibility compliance Nov 28, 2022
@sbrannen
Copy link
Member

@rstoyanchev, do you think this should be performed for the prelude in HtmlFileTransportHandler as well?

sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Nov 28, 2022
@sbrannen sbrannen closed this in 6508754 Nov 28, 2022
sbrannen added a commit that referenced this pull request Nov 28, 2022
@sbrannen
Copy link
Member

This has been merged into main in 6508754 and revised in 6e5dd64 and 164141a.

In the future, please make sure you run a full local build before submitting a PR to ensure that the changes do not break existing tests.

Thanks

sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Nov 28, 2022
sbrannen added a commit that referenced this pull request Nov 28, 2022
sbrannen added a commit to sbrannen/spring-framework that referenced this pull request Nov 28, 2022
@sbrannen sbrannen added the status: backported An issue that has been backported to maintenance branches label Nov 28, 2022
@Aashay-Chapatwala
Copy link
Contributor Author

@sbrannen Is it possible to merge this as a hotfix in 5.2.13.RELEASE version onwards as well? e.g. 5.2.23.RELEASE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants