Set detail from reason in both constructors of ResponseStatusException #29608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@singhbaljit Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@singhbaljit Thank you for signing the Contributor License Agreement! |
|
@rstoyanchev Where would I write the integration tests for this? |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
rstoyanchev
changed the title
rstoyanchev
requested changes
Nov 29, 2022
spring-web/src/main/java/org/springframework/web/server/ResponseStatusException.java
Show resolved
Hide resolved
- leftover item that was not fully resolved in a27f2e9
singhbaljit
force-pushed
the
problem_detail
branch
from
3a37e18 to
80b4294
Compare
|
That test seems flaky, its passing locally. |
|
I cant seem to retrigger to the CI pipeline. |
|
This is merged now. Thanks for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setDetail()was added to one constructor, but not the other.This fixes the issue I'm seeing where the detail is not present when using
spring.webflux.problemdetails.enabled=truein Spring Boot.