Skip to content

Apply "instanceof pattern matching" #29710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Conversation

diguage
Copy link
Contributor

@diguage diguage commented Dec 18, 2022

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 18, 2022
@sbrannen sbrannen self-assigned this Dec 18, 2022
@sbrannen sbrannen added type: task A general task in: core Issues in core modules (aop, beans, core, context, expression) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Dec 18, 2022
@sbrannen sbrannen added this to the 6.0.4 milestone Dec 18, 2022
@sbrannen sbrannen merged commit 511dab1 into spring-projects:main Dec 18, 2022
@sbrannen
Copy link
Member

This has been merged into main.

In the future, please include larger change sets in your PRs.

There are certainly other places in the code base that can benefit from "instance of pattern matching", and we would prefer to address them on a per-module basis (for example, the entire spring-aop module).

Thanks

@diguage diguage deleted the instanceof branch December 19, 2022 05:00
@diguage
Copy link
Contributor Author

diguage commented Dec 19, 2022

OK. Thank you for the tips.

I had checked all the codes of spring-aop, and only this one needed to be modified.

@sbrannen
Copy link
Member

I had checked all the codes of spring-aop, and only this one needed to be modified.

I'm not sure how you checked, because I found several other places that needed to be modified in spring-aop. See commit b71db12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants