Move blocking writeResource operation to boundedElastic #30928
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jhoeller
added
in: web
jhoeller
changed the title
|
As with #30903, this PR uses the bounded elastic scheduler for all writing operations, including zero-copy operations that do not burden the CPU. I will address this by localizing the usage of the bounded elastic scheduler to just the blocking operations. Doing so will require new method signatures for a public method, so rescheduling to 6.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 🙂
We detected a blocking call in http-codec module with the help of BlockHound:
This PR fixes the blocking code so the pipeline remains reactive end to end. :) We re-ran the tests and also compared the performance (CPU usage and latency) before and after the fix:
Before
After
