Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to HttpOnly documentation at OWASP in ResponseCookie #32663

Closed
wants to merge 1 commit into from
Closed

Update links to HttpOnly documentation at OWASP in ResponseCookie #32663

wants to merge 1 commit into from

Conversation

yhao3
Copy link
Contributor

@yhao3 yhao3 commented Apr 18, 2024

Summary

The link to the "HttpOnly" attribute explanation was leading to a 404 not found error. Updated the link to point to the correct URL: https://owasp.org/www-community/HttpOnly.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 18, 2024
@jhoeller jhoeller added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Apr 18, 2024
@jhoeller jhoeller added this to the 6.1.7 milestone Apr 18, 2024
@sbrannen sbrannen self-assigned this Apr 18, 2024
@jhoeller
Copy link
Contributor

@sbrannen let's also update that link in 6.0.x and 5.3.x

@sbrannen sbrannen closed this in 7f27ba3 Apr 18, 2024
@sbrannen
Copy link
Member

This has been merged into 6.1.x and main.

Thanks

@sbrannen sbrannen changed the title Update HttpOnly attribute link in ResponseCookie class Update links to HttpOnly documentation at OWASP in ResponseCookie Apr 18, 2024
@sbrannen sbrannen added for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x for: backport-to-6.0.x Marks an issue as a candidate for backport to 6.0.x status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.3.x Marks an issue as a candidate for backport to 5.3.x for: backport-to-6.0.x Marks an issue as a candidate for backport to 6.0.x labels Apr 18, 2024
This was referenced Apr 18, 2024
Closed
Closed
sbrannen pushed a commit that referenced this pull request Apr 18, 2024
@yhao3 @sbrannen
Update links to HttpOnly documentation at OWASP in ResponseCookie
e4ab2aa 
See gh-32663
Closes gh-32667

(cherry picked from commit 7f27ba3)
sbrannen pushed a commit to sbrannen/spring-framework that referenced this pull request Apr 18, 2024
@yhao3 @sbrannen
Update links to HttpOnly documentation at OWASP in ResponseCookie
ceeb552 
See spring-projectsgh-32663
Closes spring-projectsgh-32668

(cherry picked from commit 7f27ba3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sbrannen sbrannen

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Milestone
6.1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yhao3 @jhoeller @sbrannen @spring-projects-issues