Fix ByteBuffer concurrency issue in ConcurrentWebSocketSessionDecorator for binary messages #35517
+133
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
xeromank
force-pushed
the
fix/concurrent-binary-message-thread-safety
branch
from
b5811b8 to
23cbea7
Compare
- Test concurrent sending of shared BinaryMessage across multiple sessions - Demonstrates ByteBuffer position corruption in multi-threaded environment - Validates the need for ByteBuffer.duplicate() when handling binary messages Signed-off-by: xeroman.k <xeroman.k@gmail.com>
- Duplicate ByteBuffer before sending to avoid position conflicts - Ensure thread-safe handling of binary messages across multiple sessions Signed-off-by: xeroman.k <xeroman.k@gmail.com>
xeromank
force-pushed
the
fix/concurrent-binary-message-thread-safety
branch
from
23cbea7 to
6f39275
Compare
|
I'll rewrite this PR. |
bclozel
added
status: invalid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong PR