Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only build GraphQL once #37

Closed
wants to merge 1 commit into from
Closed

only build GraphQL once #37

wants to merge 1 commit into from

Conversation

andimarek
Copy link
Contributor

@andimarek andimarek commented Mar 5, 2021

Fix for #32
Not sure this is the right way to ensure we only have one GraphQL instance. I am wondering how a user would configure it further: maybe we need to make the following @ConditionalOnMissingBean

	@Bean
	public GraphQL graphQL(GraphQL.Builder graphQLBuilder) {
		return graphQLBuilder.build();
	}

rstoyanchev pushed a commit to rstoyanchev/spring-graphql that referenced this pull request Apr 7, 2021
@rstoyanchev rstoyanchev self-assigned this Apr 7, 2021
@rstoyanchev rstoyanchev added this to the 0.1.0 milestone Apr 7, 2021
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Apr 7, 2021
@rstoyanchev rstoyanchev linked an issue Apr 8, 2021 that may be closed by this pull request
@bclozel bclozel deleted the fix-duplicate-graphql branch May 18, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build a Single GraphQL Instance
2 participants