Skip to content

DefaultDestinationTopicResolver: Inconsistencies In Spring Cloud Environment #1961

@yvettequinby

Description

@yvettequinby

DefaultDestinationTopicResolver closes the container on ContextRefreshedEvent.

When using Spring Cloud, specifically FeignClient, some components might create a child application context that spring cloud maintains.

See 7.2 - https://cloud.spring.io/spring-cloud-netflix/multi/multi_spring-cloud-feign.html
"A central concept in Spring Cloud’s Feign support is that of the named client. Each feign client is part of an ensemble of components that work together to contact a remote server on demand, and the ensemble has a name that you give it as an application developer using the @FeignClient annotation. Spring Cloud creates a new ensemble as an ApplicationContext on demand for each named client using FeignClientsConfiguration."

This child application contexts are going to be an ApplicationEvent source for the DefaultDestinationTopicResolver component, which is defined as an ApplicationEvent listener.

DefaultDestinationTopicResolver is intended to close the container after a ContextRefreshedEvent.

When there are child application contexts (ContextRefreshedEvent emitters) we end up having some inconsistencies in the DefaultDestinationTopicResolver context lifecycle.

Pull Request: #1962

Affects Version(s): 2.7.2

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions