Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET standard release plan #187

Closed
cezarypiatekGC opened this issue Jul 11, 2019 · 23 comments
Closed

.NET standard release plan #187

cezarypiatekGC opened this issue Jul 11, 2019 · 23 comments

Comments

@cezarypiatekGC
Copy link
Contributor

Hi

I'm considering using Spring.Messaging.Nms in several projects for my company. The main obstacle that prevents me from taking it right now is the lack of the release of a version compatible with the .NET standard. I would like to know what is the current status of porting Spring.Messaging.Nms to .net standard and what are the release plans?

@mashbrno
Copy link
Contributor

mashbrno commented Sep 4, 2019

Would be great if you can create at least pre-release NuGet packages. I had to create my own Nugets to use in my own projects, but that is not generally good idea as other people don't know what to expect from such forks

@lahma
Copy link
Collaborator

lahma commented Sep 7, 2019

I just pushed changes to master and Spring.Messaging.Nms now has netstandard2.0 target, can't promise a NuGet release or a date though.

@lwqwag
Copy link

lwqwag commented Oct 14, 2019

Will next release be based on .netcore2.2 or .netcore3.0?

@lahma
Copy link
Collaborator

lahma commented Oct 14, 2019

It's netstandard 2.0 so works on both.

@lwqwag
Copy link

lwqwag commented Oct 15, 2019

Thanks for your reply

@Simulacrux
Copy link

Hi everyone,

as my fellow pre-poster wrote and also was stated in issue #167 , it would be very helpful to have official pre-release Nugets of the new Spring.Net version. Not everyone is able to compile and sign it on his own and if I understand the Milestones correct, the only open issue right now is the performance improvement. For my part, this would be a nice to have, but getting a new version (pre-release) of Spring.Net out in the world would be a nice Christmas gift.

Cheers
Simulacruxx

@michaelandrepearce
Copy link

@lahma any update here with release?

@lahma
Copy link
Collaborator

lahma commented Jan 30, 2020

Sorry for the radio silence. Currently I have little to give as I don't have permissions to the official NuGet feed. Best what I could do is to try to get some myget/GitHub feed up. The performance testing branch is not essential for the release. I believe that the version as-is with the .NET Core support is better than nothing, hopefully at least.

@gergroen
Copy link

A release would be great. @lahma Do you know who has the permissions for the official nuget feed?

@lahma
Copy link
Collaborator

lahma commented Jan 31, 2020

Based on the core package NuGet page @markpollack and @sbohlen have the keys to the kingdom 🙂

@Simulacrux
Copy link

Yes from my point of view, every possible (pre-)release would be great.

As I'm hosting my own Nuget gallery at work for our inhouse project releases, I would be quite happy with just getting a "Zip" release to Github with the .nupkg and/or DLLs in there. Or some similar way of obtaining the latest bits.

Of yourse we should try to figure out the kingdom keys, but for the short term I would be quite happy with any "workaround" release.

THX @lahma for your continuous work for Spring.Net

@michaelandrepearce
Copy link

michaelandrepearce commented Apr 20, 2020

+1 agreed, at least a release in github would be good, so people could consume a binary nuget pkg release by manually downloading and installing in local nuget repos, and then if/when nuget.org perms are sorted the packages could always be posthumously uploaded to nuget.org

another option whilst nuget.org is being sorted, is to distribute it via bintray? https://bintray.com/

or even github packages - https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-dotnet-cli-for-use-with-github-packages

@agudets
Copy link

agudets commented Jun 8, 2020

Are there any chances to have at least pre-release .net standard version in short term (1-2months)?

@mashbrno
Copy link
Contributor

mashbrno commented Jun 8, 2020

It's a bit off topic, but from my point of view - Spring is not ready for .NET Core. I spend some time trying to make it work as our code base is tightly coupled with Spring.NET. But there are many unresolved issues, which need considerable amount of time to fix:

  • there's no integration with ASP.NET Core
  • Common.Logging is not compatible with Microsoft.Extensions.Logging
  • async/await support for Spring.Data transactions
  • lack of EF Core support

We still have no successor for Spring's superb expressions and validations.

@lahma
Copy link
Collaborator

lahma commented Jun 8, 2020

  • there's no integration with ASP.NET Core

Probably doable, but require a champion to create a PR.

  • Common.Logging is not compatible with Microsoft.Extensions.Logging

Microsoft's version has won the battle so I think it would make sense to switch over to that.

  • async/await support for Spring.Data transactions

Just overloads needed?

  • lack of EF Core support

I think EF isn't supported either. What would this include?

@mashbrno
Copy link
Contributor

mashbrno commented Jun 8, 2020

async/await - there's more about NHibernate session thread safety. For sure it will end up as an overload, but quite complex one.

EF is also not supported, but it's getting mature and competitive with NHibernate. It's now suitable for wider range of projects than in 2005. Eg. NHibernate.Spatial.MsSql was full .NET for very long time (due to reference to Microsoft.SqlServer.Types).

@terrajobst
Copy link

@lahma

We just had a customer asking us about spring.net and whether it will support .NET Standard/.NET Core. You mentioned earlier that you can't promise a package. Is there anything we could help you with you?

@lahma
Copy link
Collaborator

lahma commented Oct 16, 2020

I have pinged @sbohlen about modifying the NuGet org permissions. I think I'll also have a go to get GitHub actions working to release to NuGet package repository in the near future.

@jgermanos
Copy link

I have pinged @sbohlen about modifying the NuGet org permissions. I think I'll also have a go to get GitHub actions working to release to NuGet package repository in the near future.
@lahma any ETA on the release to NuGet? thanks.

@maulik-modi
Copy link

maulik-modi commented Apr 15, 2021

@markpollack, @sbohlen and @lahma, @gjarzab ,
Is there anything we could help you with? Please release pre-release packages.

We are heavily invested in Spring.net for multiple products, It is high time we migrate to .net standard to do anything like Dockerization, getting rid of system.web, lighter application, faster performance, fewer allocations, Browser link.

@terrajobst, @Simulacrux are also interested

Someone has created pre-release package here - https://www.nuget.org/packages/D3S.Spring.Core/3.0.3-pre

@maulik-modi
Copy link

I can see that https://www.nuget.org/packages/castle.core/ is being used by Popular libraries such as EFCore, FakeItEasy etc... to provide dynamic proxy

@Simulacrux
Copy link

Hi everyone,

yes I would also available to help with a release. Did not do any Github actions until now, but did a lot of other Build processes before, so should be manageable/learnable.
I checked the other Pre-Upload in the Nuget gallery and this packages are without strong named DLLs, because at this time the signing key was not available. Therefore I downloaded the current sources and did a local build with signing and packing in Nugets. It is not tested for now from my side, but I thought I just share it here, so maybe some other could also have a look onto it.
Version is 3.0.0 and Alpha1 as Prerelease signature.

Happy Testing
Simulacrux
Spring.Nuget.3.0.0-Alpha1.zip

@lahma
Copy link
Collaborator

lahma commented Aug 2, 2021

On top of earlier progress:

  • I have now reworked the build pipeline to use NUKE build and it now builds and tests on both Windows and Linux.
  • I decided to push the 3.0.0 release to NuGet, now there's something to use at least, there may be dragons - but the original idea was to have reworked, netstandard-compatible mostly backwards compatible version out

I have spent considerable amount of my time (including part of my recent summer holiday) to get things working on .NET Core / NET5, all the permissions and setups done (collaboration with past maintainers), fighting the build system etc. Please do not expect me start fixing everything you might find, but everyone as consumer of the framework should provide pull requests to push things forward. Now publishing new versions should at least be (a lot) simpler.

There's always option to sponsor, if you want to show gratitude of the past work, this will not bind me to future work 😉

Let's consider this issue fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests