Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation Improvements #184

Closed
garyrussell opened this issue Oct 25, 2019 · 0 comments · Fixed by #298
Closed

Annotation Improvements #184

garyrussell opened this issue Oct 25, 2019 · 0 comments · Fixed by #298
Milestone
2.0.0-M1

Comments

@garyrussell
Copy link
Contributor

Evaluate *Expression properties at runtime instead of during annotation parsing.

See https://stackoverflow.com/questions/58559733/can-springs-retryable-or-retrytemplate-use-retry-after-header-for-dynamic-backo/58560029#58560029

We could either enhance the current policies and backoff policies to accept expressions directly or, after moving to 2.0 (and Java 8) Supplier<?>s and leave the expression evaluation in the AnnotationAwareRetryOperationsInterceptor.
@garyrussell garyrussell mentioned this issue Mar 18, 2021
Closed
@garyrussell garyrussell added this to the 2.0.0-M1 milestone Apr 18, 2022
@garyrussell garyrussell mentioned this issue Apr 18, 2022
Closed
garyrussell added a commit to garyrussell/spring-retry that referenced this issue May 3, 2022
@garyrussell
spring-projectsGH-184: Expression Evaluatin at Runtime
e60ea70 
Resolves spring-projects#184
garyrussell added a commit to garyrussell/spring-retry that referenced this issue May 3, 2022
@garyrussell
spring-projectsGH-184: Expression Evaluation at Runtime
b6a7632 
Resolves spring-projects#184
@garyrussell garyrussell mentioned this issue May 3, 2022
Merged
artembilan pushed a commit that referenced this issue May 4, 2022
@garyrussell
GH-184: Expression Evaluation at Runtime
47c1e52 
Resolves #184

* Remove `args` property when using stateful (including CircuitBreaker).

Other polishing from review.

* Docs for stateful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging a pull request may close this issue.

GH-184: Expression Evaluation at Runtime garyrussell/spring-retry
1 participant
@garyrussell