Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MessageSourceAware from ExceptionTranslationWebFilter #11057

Closed
eleftherias opened this issue Apr 5, 2022 · 0 comments
Closed

Remove MessageSourceAware from ExceptionTranslationWebFilter #11057

eleftherias opened this issue Apr 5, 2022 · 0 comments
Assignees
@eleftherias
Labels
in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Milestone
6.0.0-M4

Comments

@eleftherias
Copy link
Contributor

The ExceptionTranslationWebFilter used to retrieve an exception message from a MessageSource.

This was removed as part of gh-10864 because it was a blocking call and did not align with the other WebFilters.

Since the message is no longer retrieved, the filter does not need to implement MessageSourceAware.
@eleftherias eleftherias added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement type: breaks-passivity A change that breaks passivity with the previous release labels Apr 5, 2022
@eleftherias eleftherias added this to the 6.0.0-M4 milestone Apr 5, 2022
@eleftherias eleftherias self-assigned this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

Labels
in: web An issue in web modules (web, webmvc) type: breaks-passivity A change that breaks passivity with the previous release type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M4
Development

No branches or pull requests
1 participant
@eleftherias