SEC-1887: Cannot override (protected) DefaultMethodSecurityExpressionHandler.createSecurityExpressionRoot #2115

Closed
spring-issuemaster opened this Issue Jan 9, 2012 · 2 comments

1 participant

@spring-issuemaster

Dave Syer (Migrated from SEC-1887) said:

There is some inconsistent visibility of the internals: DefaultMethodSecurityExpressionHandler.createSecurityExpressionRoot(Authentication, MethodInvocation) is protected but it returns an instance of a package private class MethodSecurityExpressionRoot. This would be fine except that {[DefaultMethodSecurityExpressionHandler.filter(Object, Expression, EvaluationContext)}} then makes an assumption that the root is of this precise type, and therefore createSecurityExpressionRoot actually cannot be overridden (which would be quite useful).

@spring-issuemaster

Luke Taylor said:

Andrei has been looking at something along these lines and has submitted a pull request which I think should cover this.

@spring-issuemaster

Luke Taylor said:

Marking as fixed, following Andrei's commit.

@spring-issuemaster spring-issuemaster added this to the 3.1.1 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment