Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2ResourceServerSpec should allow its authentication manager to be configurable #5750

Closed
jzheaux opened this issue Aug 28, 2018 · 0 comments · Fixed by #5752
Closed

OAuth2ResourceServerSpec should allow its authentication manager to be configurable #5750

jzheaux opened this issue Aug 28, 2018 · 0 comments · Fixed by #5752
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone
5.1.0.RC2

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 28, 2018 •
edited

If a user wanted to supply a custom authentication manager for a Reactive OAuth2 Resource Server, then she would need to create the entire AuthenticationWebFilter from scratch.

Since on the Reactive side of Spring Security, authentication managers are typically separated by Authentication type, it makes sense to expose OAuth2 Resource Server's authentication manager to be configurable:

http
    .oauth2ResourceServer()
        .jwt()
            .authenticationManager(customAuthenticationManager())
@jzheaux jzheaux added Reactive in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 28, 2018
@jzheaux jzheaux added this to the 5.1.0.RC2 milestone Aug 28, 2018
@jzheaux jzheaux self-assigned this Aug 28, 2018
@jzheaux jzheaux added this to jzheaux in Security Team Aug 28, 2018
@jzheaux jzheaux moved this from jzheaux to In Progress in Security Team Aug 28, 2018
@jzheaux jzheaux mentioned this issue Aug 28, 2018
Merged
@jzheaux jzheaux moved this from In Progress to jzheaux in Security Team Aug 28, 2018
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 31, 2018
@jzheaux
AuthenticationManager for OAuth2ResourceServerSpec
bd73b86 
This makes the AuthenticationManager used by the OAuth2 Resource
Server configurable, focusing at this point on the Jwt use case.

Fixes: spring-projectsgh-5750
rwinch pushed a commit that referenced this issue Sep 5, 2018
@jzheaux @rwinch
AuthenticationManager for OAuth2ResourceServerSpec
932ea24 
This makes the AuthenticationManager used by the OAuth2 Resource
Server configurable, focusing at this point on the Jwt use case.

Fixes: gh-5750
@jzheaux jzheaux removed this from jzheaux in Security Team Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.1.0.RC2
Development

Successfully merging a pull request may close this issue.

AuthenticationManager for OAuth2ResourceServerSpec jzheaux/spring-security
1 participant
@jzheaux