-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)status: ideal-for-contributionAn issue that we actively are looking for someone to help us withAn issue that we actively are looking for someone to help us withtype: enhancementA general enhancementA general enhancement
Description
Summary
Anyone wanting to take this on can request to take the whole thing on or just one step (but it must be the first step that has not been completed).
Step 1
We should add a default method to RequestMatcher
that looks like this:
default MatchResult matcher(HttpServletRequest request) {
boolean match = matches(request);
return new MatchResult(match);
}
The MatchResult
should look similar to ServerWebExchangeMatcher.MatchResult
except it uses servlet request and non-reactive types.
Step 2
Then implementations of RequestVariablesExtractor
should be updated to implement the matcher
method and RequestVariablesExtractor
should be deprecated.
Step 3
Usage of RequestVariablesExtractor
or types that are assigned to AntPathRequestMatcher
should be replaced with the new method.
Metadata
Metadata
Assignees
Labels
in: webAn issue in web modules (web, webmvc)An issue in web modules (web, webmvc)status: ideal-for-contributionAn issue that we actively are looking for someone to help us withAn issue that we actively are looking for someone to help us withtype: enhancementA general enhancementA general enhancement