Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CookieServerCsrfRepositoryTests should not start domain with a dot #7500

Closed
jzheaux opened this issue Sep 30, 2019 · 0 comments
Closed

CookieServerCsrfRepositoryTests should not start domain with a dot #7500

jzheaux opened this issue Sep 30, 2019 · 0 comments
Assignees
@jzheaux
Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.2.0

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 30, 2019

As of spring-projects/spring-framework#23693, Spring Framework's ResponseCookie throws an exception if the provided cookie domain is preceded by a dot, e.g. .example.com.

CookieServerCsrfTokenRepository should be updated accordingly.
@jzheaux jzheaux self-assigned this Sep 30, 2019
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Sep 30, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 30, 2019
jzheaux added a commit that referenced this issue Sep 30, 2019
@jzheaux
CookieServerCsrfTokenRepositoryTests Leading Dot
8589580 
ResponseCookie removed support for having a leading dot in the cookie
domain.

Fixes gh-7500
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@jzheaux @spring-projects-issues