BCryptPasswordEncoder.encode() throws NPE

[alan-czajkowski]

spring-security/crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCryptPasswordEncoder.java

Line 108 in 1de0cf5

return BCrypt.hashpw(rawPassword.toString(), salt);

BCryptPasswordEncoder.encode() throws a Null Pointer Exception (NPE) when passing in a null rawPassword and then rawPassword.toString() is called inside the method.

This method can and should be made null-safe, either:

• check for null and return null, or
• throw some kind of exception

[rwinch]

@alan-czajkowski We don't want to return null for the encoding, but I'd be open to returning an IllegalArgumentException. Would you be willing to submit a PR?

[alan-czajkowski]

@rwinch I'll submit a PR

[alan-czajkowski]

@rwinch done: #8330