-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Closed
Labels
in: saml2An issue in SAML2 modulesAn issue in SAML2 modulestype: enhancementA general enhancementA general enhancement
Milestone
Description
OpenSamlAuthenticationProvider
leverages a package-private class OpenSamlImplementation
to remove boilerplate from its own class.
However, this boilerplate is only removed for OpanSamlAuthenticationProvider
and for no other class. For example, OpenSamlImplementation
has a resolve
method that's only called by OpenSamlAuthenticationProvider
.
Since these methods are only used by OpenSamlAuthenticationProvider
, they should be inlined. They can always be re-extracted should the need arise in the future.
Metadata
Metadata
Assignees
Labels
in: saml2An issue in SAML2 modulesAn issue in SAML2 modulestype: enhancementA general enhancementA general enhancement