Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve HttpSessionSecurityContextSessionRepository Performance #9391

Closed
spring-projects-issues opened this issue Jan 28, 2021 · 3 comments
Closed

Improve HttpSessionSecurityContextSessionRepository Performance #9391

spring-projects-issues opened this issue Jan 28, 2021 · 3 comments
Assignees
@rwinch
Labels
type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Milestone
5.3.8

Comments

@spring-projects-issues
Copy link

Backport of gh-9387
@spring-projects-issues spring-projects-issues added type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement labels Jan 28, 2021
@spring-projects-issues spring-projects-issues added this to the 5.3.7 milestone Jan 28, 2021
@rwinch rwinch mentioned this issue Jan 28, 2021
Closed
@rwinch rwinch closed this as completed Feb 11, 2021
@CaesarGao
Copy link

Looking at the commit history, it doesn't appear that the HttpSessionSecurityContextSessionRepository.java changes have been made to the 5.3.X line. The file still shows it was last modified 2 years ago.
Can see the change reflected in the 5.2.X and 5.4.X line.
Could you review and confirm.

@rwinch rwinch self-assigned this Mar 12, 2021
@rwinch rwinch modified the milestones: 5.3.7, 5.3.8 Mar 12, 2021
@rwinch
Copy link
Member

rwinch commented Mar 12, 2021 •
edited
Loading

I wonder if the reason you cannot find the commit it is due to the fact this was incorrectly marked for 5.3.7 instead of 5.3.8? The commit is 38e9e8c Due to a problem with the release of 5.3.7 we used a release branch and the commit that made the change for the tag is 9a49a86

@CaesarGao
Copy link

CaesarGao commented Mar 13, 2021 •
edited
Loading

Thanks, the branch 5.3.x looks okay with the commit 38e9e8c. But the commit 9a49a86 for tag 5.3.8.RELEASE seems only made changes for HttpSessionSecurityContextSessionRepositoryTest.java, HttpSessinoSecurityContextSessionRepository.java still remain the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
type: backport An issue that is a backport of another issue to a maintenance branch type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.8
Development

No branches or pull requests
3 participants
@rwinch @spring-projects-issues @CaesarGao