Skip to content

Add method to customize EntityDescriptor and SPSSODescriptor #10925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add method to customize EntityDescriptor and SPSSODescriptor #10925

wants to merge 1 commit into from

Conversation

ugrave
Copy link
Contributor

@ugrave ugrave commented Mar 2, 2022

This PR does the following:

  • Adds a new method to the OpenSamlMetadataResolver to allow customization of the EntityDescriptor and SPSSODescriptor before SAML metadata is generated

Closes gh-10839

@ugrave ugrave mentioned this pull request Mar 2, 2022
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 2, 2022
@eleftherias eleftherias added in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 3, 2022
jzheaux
jzheaux requested changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ugrave! I've left my feedback inline.

@ugrave ugrave requested a review from jzheaux March 4, 2022 07:21
@jzheaux
Copy link
Contributor

jzheaux commented Mar 4, 2022

Thanks, @ugrave! I've merged this into main and 5.7.x. I also added a polish commit to add JavaDoc and change to EntityDescriptorParameters#getRelyingPartyRegistration to align with other parameter objects like AuthnRequestParameters and LogoutRequestParameters.

@jzheaux jzheaux closed this Mar 4, 2022
@jzheaux jzheaux added this to the 5.7.0-M3 milestone Mar 4, 2022
@ugrave ugrave deleted the gh-10839 branch May 12, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.7.0-M3
Development

Successfully merging this pull request may close these issues.

Add OpenSamlMetadataResolver#setEntityDescriptorCustomizer
4 participants
@ugrave @jzheaux @eleftherias @spring-projects-issues