Change TestingAuthenticationToken to Accept Collection GrantedAuthorities #12953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
changed the title
jzheaux
requested changes
May 12, 2023
There was a problem hiding this comment.
Thanks, @lmartelli, for the PR! I've left my feedback inline.
Additionally, will you please update the copyright years for each file you change? Please align those copyright changes with the two commits you've set up.
core/src/main/java/org/springframework/security/authentication/TestingAuthenticationToken.java
Show resolved
Hide resolved
jzheaux
added
in: test
So that callers do not have to cast. Closes spring-projectsgh-12953
Restore List constructor to retain binary compatibility.
jzheaux
approved these changes
Jun 5, 2023
jzheaux
pushed a commit
that referenced
this pull request
Jun 22, 2023
So that callers do not have to cast. Closes gh-12953
|
Thanks, @lmartelli! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.