Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note about the fact that if the CSRF protection is disabled in configuration, no logout confirmation page is shown to the user and the logout is performed directly. #13442

Closed
wants to merge 3 commits into from

Conversation

abramofranchetti
Copy link
Contributor

Added a note about the fact that if the CSRF protection is disabled in configuration, no logout confirmation page is shown to the user and the logout is performed directly.

@pivotal-cla
Copy link

@abramofranchetti Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 30, 2023
@pivotal-cla
Copy link

@abramofranchetti Thank you for signing the Contributor License Agreement!

@sjohnr sjohnr self-assigned this Jul 13, 2023
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement labels Jul 13, 2023
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abramofranchetti! In addition to my inline feedback, will you please rebase and squash your commits so that there is only one?

docs/modules/ROOT/pages/servlet/authentication/logout.adoc Outdated Show resolved Hide resolved
 change [the CSRF protection] to [CSRF protection]?

 change direclty to directly.
@jzheaux jzheaux removed the status: waiting-for-triage An issue we've not yet triaged label Oct 16, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Oct 16, 2023

@abramofranchetti, I went ahead and squashed the commits myself. This is now merged into main in ab478a1

@jzheaux jzheaux closed this Oct 16, 2023
@jzheaux jzheaux assigned jzheaux and unassigned sjohnr Oct 16, 2023
@jzheaux jzheaux added this to the 6.2.0-RC2 milestone Oct 16, 2023
@jzheaux jzheaux added type: bug A general bug and removed type: enhancement A general enhancement labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants