Skip to content

Conversation

abimael-turing
Copy link

@abimael-turing abimael-turing commented May 8, 2024

The updated description now provides comprehensive details about the securityMatcher and the concept of multiple filter chains. This enhanced explanation aims to offer a deeper understanding of how these components work together to strengthen security measures in the application.

Closes gh-14419

…securityMatcher and the concept of multiple filter chains.

Closes 14419
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 8, 2024
@abimael-turing
Copy link
Author

@sjohnr, I have submitted a pull request. Please review it when you have a moment. Thank you.

Copy link
Contributor

@sjohnr sjohnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @abimael-turing! However I don't know that this is the change I had in mind with gh-14419. Please see feedback below and let me know if you have any questions.

@abimael-turing abimael-turing requested a review from sjohnr May 17, 2024 17:48
@sjohnr sjohnr added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 24, 2024
sjohnr added a commit that referenced this pull request May 24, 2024
@sjohnr
Copy link
Contributor

sjohnr commented May 24, 2024

Thanks @abimael-turing and congrats on your first contribution!

I have merged this as 046a1fc. However, as-is the change was still very similar to the previous example but was more complex. To address this, I added a few new sections to specifically explain concepts I had in mind with gh-14419, and reworked your example to be a more real-world capstone to the new sections. All of this was added via
2482e8e.

@sjohnr sjohnr closed this May 24, 2024
@sjohnr sjohnr added this to the 6.4.0-M1 milestone May 24, 2024
sjohnr added a commit that referenced this pull request May 24, 2024
sjohnr added a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description of securityMatcher and multiple filter chains could use more details
4 participants