GH-15201 Introduce ExpressionJwtGrantedAuthoritiesConverter to extract nested authorities via SpEL expression #15202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sjohnr
added
type: enhancement
jzheaux
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Thanks for the PR, @thomasdarimont! And for your patience as I got around to it. I've left a piece of feedback inline.
...framework/security/oauth2/server/resource/authentication/JwtGrantedAuthoritiesConverter.java
Outdated
Show resolved
Hide resolved
thomasdarimont
force-pushed
the
issue/GH-15201-jwt-nested-authorities
branch
from
20a08b7 to
204d74e
Compare
thomasdarimont
changed the title
thomasdarimont
changed the title
thomasdarimont
force-pushed
the
issue/GH-15201-jwt-nested-authorities
branch
3 times, most recently
from
4df49bd to
b72f116
Compare
|
Tried to make checkstyle happy. |
jzheaux
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks for the updates, @thomasdarimont! I've left some feedback additional inline; thanks for taking a look.
...security/oauth2/server/resource/authentication/ExpressionJwtGrantedAuthoritiesConverter.java
Outdated
Show resolved
Hide resolved
...security/oauth2/server/resource/authentication/ExpressionJwtGrantedAuthoritiesConverter.java
Outdated
Show resolved
Hide resolved
...security/oauth2/server/resource/authentication/ExpressionJwtGrantedAuthoritiesConverter.java
Outdated
Show resolved
Hide resolved
thomasdarimont
force-pushed
the
issue/GH-15201-jwt-nested-authorities
branch
3 times, most recently
from
d77ef40 to
3e96b56
Compare
…ith an expression This helps to reduce custom code necessary to extract roles from deeply nested claims. Closes spring-projects#15201 Signed-off-by: Thomas Darimont <thomas.darimont@googlemail.com>
jzheaux
force-pushed
the
issue/GH-15201-jwt-nested-authorities
branch
from
3e96b56 to
6a7f2f1
Compare
jzheaux
approved these changes
Sep 23, 2024
|
Thanks, @thomasdarimont! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to reduce custom code necessary to extract roles from deeply nested claims.
Fixes #15201