Add Support JDBC Repositories For WebAuthn #16282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: web
rwinch
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Thanks for the PR @franticticktick! I've left feedback inline
web/src/main/resources/org/springframework/security/user-entities-schema.sql
Outdated
Show resolved
Hide resolved
...gframework/security/web/webauthn/management/JdbcPublicKeyCredentialUserEntityRepository.java
Show resolved
Hide resolved
...gframework/security/web/webauthn/management/JdbcPublicKeyCredentialUserEntityRepository.java
Outdated
Show resolved
Hide resolved
...gframework/security/web/webauthn/management/JdbcPublicKeyCredentialUserEntityRepository.java
Show resolved
Hide resolved
franticticktick
force-pushed
the
gh-16224
branch
from
139a8a0 to
21da51d
Compare
franticticktick
force-pushed
the
gh-16224
branch
from
21da51d to
aa64c44
Compare
rwinch
approved these changes
Dec 20, 2024
|
Thanks for the Pull Request! This is now merged into main 😄 |
rwinch
added a commit
that referenced
this pull request
Jan 18, 2025
kwondh5217
pushed a commit
to kwondh5217/spring-security
that referenced
this pull request
Feb 4, 2025
Issue spring-projectsgh-16282 Signed-off-by: Daeho Kwon <trewq231@naver.com>
ziqin
reviewed
Feb 18, 2025
Comment on lines
+133
to
+142
| @Override | ||
| public void save(CredentialRecord record) { | ||
| Assert.notNull(record, "record cannot be null"); | ||
| List<SqlParameterValue> parameters = this.credentialRecordParametersMapper.apply(record); | ||
| try (LobCreator lobCreator = this.lobHandler.getLobCreator()) { | ||
| PreparedStatementSetter pss = new LobCreatorArgumentPreparedStatementSetter(lobCreator, | ||
| parameters.toArray()); | ||
| this.jdbcOperations.update(SAVE_CREDENTIAL_RECORD_SQL, pss); | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe an insert-or-update is also required here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16224