Update servlet test method docs to use include-code #17749
Merged
+1,767
−519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jkuhel
force-pushed
the
gh-16226-servlet-test-method
branch
from
75cfd27 to
a923ec8
Compare
rwinch
added
in: docs
rwinch
force-pushed
the
gh-16226-servlet-test-method
branch
from
a923ec8 to
bf08bc4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
References spring-projectsgh-16226 Signed-off-by: Joe Kuhel <4983938+jkuhel@users.noreply.github.com>
Spring Security migrated the copyright to use -present to simplify the headers. This commit aligns the header.
Previously parameters were passed in unnecessarily. This removes the unnecessary paramaters.
This adds a static import for assertThat in the Kotlin docs code
rwinch
force-pushed
the
gh-16226-servlet-test-method
branch
from
bf08bc4 to
62b5b1a
Compare
|
Thanks for the PR @jkuhel! I've rebased it, added a few minor changes, and it will be merged into 6.5.x as soon as the build passes |
|
Perfect! Thanks @rwinch! I made note to include these changes in future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Servlet test method ascii docs to use
include-codeblock macro.Also, added additional tests demonstrating usage of the
@WithMockUser,@WithUserDetails,@WithMockUser, and a custom@WithMockCustomUserannotations based on existing tests inorg/springframework/security/test/context/showcasein thespring-security-testmodule.References #16226