SEC-1915 Add cutomisation of search filter in ActiveDirectoryLdapAuthenticationProvider #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default AD search filter is currently hardcoded but in some setups needs to be adjusted. Adding two properties to ActiveDirectoryLdapAuthenticationProvider: - searchFilter - the LDAP search filter to use when looking up authorities - searchByBindPrincipal - whether to use username or bind principal (user@domain) Unit tests included.
|
I have signed the terms of SpringSource Individual Contributor License Agreement. |
|
What's up with this? Seems like a straightforward/reasonable change. (and one I need!) |
|
@brentlemons Not sure, perhaps it needs upvote in https://jira.springsource.org/browse/SEC-1915 |
This was referenced Feb 5, 2016
Closed
bclozel
added a commit
to bclozel/spring-security
that referenced
this pull request
Jan 4, 2017
remove alt attribute in <div>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default AD search filter is currently hardcoded but in some setups
needs to be adjusted.
Adding two properties to ActiveDirectoryLdapAuthenticationProvider:
authorities
(user@domain)
Unit tests included.