Add localization to error messages from ExceptionTranslationFilter #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgrandja any feedback? |
jgrandja
added
type: enhancement
jgrandja
previously requested changes
Oct 23, 2017
There was a problem hiding this comment.
Thanks for the PR @britter !
There has been very little updates to the localization of error messages in the past few years as it's not recommended to give any information to potential attackers on what the resulting error was. However, the updates you have provided are fine so I'll merge this PR after you apply the requested changes from my comments and add a test.
| @@ -83,6 +86,8 @@ | |||
|
|
|||
| private RequestCache requestCache = new HttpSessionRequestCache(); | |||
|
|
|||
| private MessageSourceAccessor messages = SpringSecurityMessageSource.getAccessor(); | |||
| @@ -0,0 +1 @@ | |||
| ExceptionTranslationFilter.insufficientAuthentication=Full authentication is required to access this resource | |||
There was a problem hiding this comment.
Add this key to messages.properties (default bundle) as well
|
I need some time to work on a test, since I have to understand how the current tests work and how to make the test reliable on different system locales. Thank you! |
britter
force-pushed
the
insufficient-authentication-messages
branch
from
af837a8 to
ee54038
Compare
britter
force-pushed
the
insufficient-authentication-messages
branch
from
ee54038 to
c6e9376
Compare
|
@jgrandja all done. Let's see what Travis thinks. |
thomasdarimont
pushed a commit
to thomasdarimont/spring-security
that referenced
this pull request
Apr 25, 2018
This was referenced Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In by simple Spring Boot application with Basic Authentication, I can add localization and custom messages if somebody tries to access a resource with wrong credentials. This is implemented in
AbstractUserDetailsAuthenticationProvider.However when somebody forgets to add authentication information the
ExceptionTranslationFilterwill throw anInsufficientAuthenticationException. Since the message is hard coded, there is no easy way to customize or localize the error message.This PR adds localization using message bundles and a
MessageSourceAccessorthe same way as it is implemented inAbstractUserDetailsAuthenticationProvider.