Skip to content

Change default scope to 'read:user' for GitHub #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change default scope to 'read:user' for GitHub #4893

wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

I think the read:user(read-only scope) is a more proper scope as OAuth 2.0 Login.
WDYT?

@jgrandja jgrandja self-assigned this Dec 12, 2017
@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Dec 12, 2017
@jgrandja jgrandja added this to the 5.0.1 milestone Dec 12, 2017
@jgrandja jgrandja added the type: enhancement A general enhancement label Dec 12, 2017
@jgrandja jgrandja closed this in bd5d0bc Dec 12, 2017
@jgrandja
Copy link
Contributor

Thanks for the PR @kazuki43zoo. This is now in master.

@kazuki43zoo kazuki43zoo deleted the change-default-scope-for-github branch December 12, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kazuki43zoo @jgrandja