Skip to content

Conversation

ThomasVitale
Copy link
Contributor

  • Add "issuerUri" attribute to ClientRegistration.providerDetails for OpenID Connect Discovery 1.0 or OAuth 2.0 Authorization Server Metadata.
  • Validate OidcIdToken "iss" claim against the OpenID Provider "issuerUri" value.
  • Update documentation for client registration: it includes issuer-uri property now.

Fixes gh-8326

- Add "issuerUri" attribute to ClientRegistration.providerDetails for OpenID Connect Discovery 1.0 or OAuth 2.0 Authorization Server Metadata.
- Validate OidcIdToken "iss" claim against the OpenID Provider "issuerUri" value.
- Update documentation for client registration: it includes issuer-uri property now.

Fixes gh-8326
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 7, 2020
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 14, 2020
@jgrandja jgrandja added this to the 5.4.0-M2 milestone May 15, 2020
jgrandja added a commit that referenced this pull request May 15, 2020
@jgrandja
Copy link
Contributor

Thanks for the PR @ThomasVitale ! I went ahead and added a polish commit to get this merged. This is now in master.

@jgrandja jgrandja closed this May 15, 2020
@ThomasVitale
Copy link
Contributor Author

Perfect, thanks @jgrandja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding ClientRegistration.providerDetails.issuerUri
3 participants