Replacing md5 with sha256 token based remember me services #8580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
in: web
rwinch
requested changes
May 21, 2020
There was a problem hiding this comment.
Thanks for the PR. We need to remain passive, so we would want to allow configuring the algorithm vs changing it. We could consider changing it by default in Spring Security 6 though.
An alternative would be to do something like we did with passwords and have a prefix that specifies the algorithm that is being used. If no algorithm is specified it would default to MD5
|
Closing because the requested changes have not been made. Please feel free to discuss on the related issue before opening a new PR. |
rwinch
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #8580