Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jun 26, 2020

Implement R2dbcReactiveOuath2AuthorizedClientService which persists the
Oauth2AuthorizedClient in a sql database

Update gradle properties to use the 5.3.0-SNAPSHOT version of spring
framework (take advantage of the r2dbc integration)

Add optional depedency to the spring-r2dbc module

Add test compile dependencies to r2dbc-h2 and r2dbc-test

Closes gh-7890

@jgrandja
Copy link
Contributor

@ovidiupopa91 Thanks for the PR ! Overall this looks good. Spring Framework 5.3.0 GA is planned for Oct 27 so I'll review this a couple weeks beforehand and we'll merge shortly after Oct 27. Just wanted to give you an update.

@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 21, 2020
@jgrandja jgrandja added this to the 5.5.0-M1 milestone Sep 21, 2020
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ovidiupopa91. Please see comments inline.

Also, please rebase on master.

Then run the build and you'll notice code formatting errors, which you can auto-correct by following the console prompt.

@ghost
Copy link
Author

ghost commented Oct 23, 2020

Hi @jgrandja,

fixed all comments, format and checkstyle issues.

@ghost ghost requested a review from jgrandja October 26, 2020 05:53
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @ovidiupopa91. I left a couple of minor comments.

Also, please squash the commits after you apply the last updates and we should be ready to merge.

@ghost ghost force-pushed the gh-7890 branch 4 times, most recently from 5320ee1 to 56cf6eb Compare October 27, 2020 12:18
@ghost ghost requested a review from jgrandja October 27, 2020 12:43
Implement R2dbcReactiveOuath2AuthorizedClientService which persists the
Oauth2AuthorizedClient in a sql database

R2dbcReactiveOuath2AuthorizedClientService is using the spring-r2dbc
module to persist/load Oauth2AuthorizedClient to/from a sql database

Add optional depedency to the spring-r2dbc module
Add test compile dependencies to r2dbc-h2 and r2dbc-test

Closes spring-projectsgh-7890
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Oct 29, 2020
@jgrandja
Copy link
Contributor

Thanks for the great work @ovidiupopa91 ! This is now in master.

@jgrandja jgrandja closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide reactive JDBC implementation of ReactiveOAuth2AuthorizedClientService
3 participants