Make Csrf cookie secure flag configurable (WebFlux) #9679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Apr 26, 2021
There was a problem hiding this comment.
Thanks for the PR @ThomasVitale!
I've left a couple of comments.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2002-2019 the original author or authors. | |||
| * Copyright 2002-2020 the original author or authors. | |||
There was a problem hiding this comment.
That's awkward :) I fixed it.
.../main/java/org/springframework/security/web/server/csrf/CookieServerCsrfTokenRepository.java
Show resolved
Hide resolved
eleftherias
added
in: web
Make the XSRF-TOKEN cookie secure flag configurable in CookieServerCsrfTokenRepository. Closes gh-9678
|
@eleftherias thanks for reviewing the PR. I have addressed your comments and pushed an update. |
|
Thanks @ThomasVitale! This is now merged into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the XSRF-TOKEN cookie secure flag configurable in CookieServerCsrfTokenRepository.
Closes gh-9678