Skip to content

Access Token Response supports any data type #9779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2021
Merged

Access Token Response supports any data type #9779

merged 1 commit into from
Jun 1, 2021

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented May 18, 2021 •
edited
Loading

Changed the converter used to convert a map into an OAuth2AccessTokenResponse to
support any object as the value, including json numbers and nested objects. Also
deprecated old setters/constructors and added new setters/factory methods.

Closes gh-9685

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 18, 2021
@sjohnr sjohnr marked this pull request as draft May 19, 2021 15:59
@sjohnr sjohnr marked this pull request as ready for review May 19, 2021 22:35
@sjohnr sjohnr requested a review from jgrandja May 20, 2021 17:46
@sjohnr sjohnr added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels May 21, 2021
@jgrandja jgrandja changed the title Add support for a more complex access token response Access Token Response supports any data type May 25, 2021
@jgrandja jgrandja added this to the 5.6.0-M1 milestone May 25, 2021
@jgrandja jgrandja added type: enhancement A general enhancement type: bug A general bug and removed type: enhancement A general enhancement labels May 25, 2021
jgrandja
jgrandja requested changes May 25, 2021
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjohnr. Please see review comments.

@sjohnr sjohnr requested a review from jgrandja May 26, 2021 20:30
jgrandja
jgrandja requested changes May 31, 2021
View reviewed changes
Copy link
Contributor

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @sjohnr. After you apply the updates as per review, please go ahead and merge to main.

Also, please ensure the commit comment is up-to-date and as well delete the gh-9685 branch after you merge.

@jgrandja jgrandja added type: enhancement A general enhancement and removed type: bug A general bug labels May 31, 2021
Access Token Response supports any data type
dd9043b 
Changed the converter used to convert a map into an OAuth2AccessTokenResponse to
support any object as the value, including json numbers and nested objects. Also
deprecated old classes/setters and added new classes/setters.

Closes gh-9685
@sjohnr sjohnr merged commit 10de63c into main Jun 1, 2021
@sjohnr sjohnr deleted the gh-9685 branch June 1, 2021 19:38
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label Jun 2, 2021
@sjohnr sjohnr mentioned this pull request Jul 12, 2021
Merged
sjohnr pushed a commit to sjohnr/spring-security that referenced this pull request Jul 12, 2021
Remove wildcard from generics in converter
3295605 
Polish spring-projectsgh-9779
sjohnr pushed a commit that referenced this pull request Jul 13, 2021
@sjohnr
Remove wildcard from generics in converter
f5266c7 
Polish gh-9779
akohli96 pushed a commit to akohli96/spring-security that referenced this pull request Aug 25, 2021
Remove wildcard from generics in converter
26d268c 
Polish spring-projectsgh-9779
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja jgrandja requested changes

Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging this pull request may close these issues.

Add support for any data type in Access Token Response
3 participants
@sjohnr @jgrandja @spring-projects-issues