Skip to content

Support for X509 Certificate in RsaKeyConverters #9736 #9853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

Support for X509 Certificate in RsaKeyConverters #9736 #9853

merged 1 commit into from
Jul 12, 2021

Conversation

shazin
Copy link
Contributor

@shazin shazin commented Jun 2, 2021

Support for X509 Certificate in RsaKeyConverters

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 2, 2021
@eleftherias eleftherias added in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 3, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone Jun 4, 2021
jzheaux
jzheaux requested changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shazin! I've left some feedback inline.

@shazin shazin requested a review from jzheaux July 1, 2021 18:25
@shazin
Copy link
Contributor Author

shazin commented Jul 1, 2021

@jzheaux Thanks for the review comments. Those are addressed and PR is updated.

@jzheaux
Copy link
Contributor

jzheaux commented Jul 1, 2021

Thanks, @shazin! For some reason, the PR includes several unrelated commits. Will you please rebase and force push your PR?

@shazin
Copy link
Contributor Author

shazin commented Jul 2, 2021

Thanks, @shazin! For some reason, the PR includes several unrelated commits. Will you please rebase and force push your PR?

@jzheaux Rebased and pushed only the commits to PR.

jzheaux
jzheaux requested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shazin! In preparation for merging, will you please squash your commits and change your final commit message to something like the following:

Add X.509 Certificate Support

Closes gh-9736

When the commit uses the word "closes" this alerts GitHub to close the ticket once this PR is merged.

@shazin
Copy link
Contributor Author

shazin commented Jul 8, 2021

Thanks, @shazin! In preparation for merging, will you please squash your commits and change your final commit message to something like the following:

Add X.509 Certificate Support

Closes gh-9736

When the commit uses the word "closes" this alerts GitHub to close the ticket once this PR is merged.

Done. Thanks for the review.

@jzheaux jzheaux merged commit 5f7d871 into spring-projects:main Jul 12, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jul 12, 2021

Thanks, @shazin! This is now merged into main in 5f7d871.

I also added a polish that errors instead of returning null and only skips the header for the given format in 01af787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

Successfully merging this pull request may close these issues.
4 participants
@shazin @jzheaux @eleftherias @spring-projects-issues