New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SessionRepository.save(Session) on non-dirty Sessions. #12

Closed
jxblum opened this Issue Nov 3, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@jxblum
Copy link
Member

jxblum commented Nov 3, 2018

Currently, Spring Session core performs a "commit" of a Session twice during the HTTP request/response processing cycle. This double commit ends up calling SessionRepository.save(Session) twice.

The commit/save, more often than not, results in a non-dirty Session update. In fact I have not seen a case where the Session has become dirty again after it was saved the first time during the HTTP request/response processing cycle. Of course, more research is needed to actually confirm an update to the Session would not occur in some other code path after the first save, such as a Servlet Filter.

Anyway, more details to follow...

@rwinch FYI, ^^^^

@jxblum jxblum self-assigned this Nov 3, 2018

@jxblum jxblum added this to the 2.1.1.RELEASE milestone Nov 3, 2018

@jxblum

This comment has been minimized.

Copy link
Member Author

jxblum commented Nov 3, 2018

If this change is warranted, then it will also be included/back-ported to the SSDG 2.0.7.RELEASE.

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 7, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 7, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 7, 2018

@jxblum jxblum closed this in 9f810ed Nov 7, 2018

jxblum added a commit that referenced this issue Nov 8, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 8, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 8, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 8, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 9, 2018

jxblum added a commit to jxblum/spring-session-data-geode that referenced this issue Nov 9, 2018

@jxblum jxblum added complete and removed investigating labels Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment