-
Notifications
You must be signed in to change notification settings - Fork 396
SHL-106: Java Configuration support #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHL-106: Java Configuration support #66
Conversation
robinhowlett
commented
Mar 19, 2015
- Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan
- Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration
- Updated docbook-reference-plugin dependency group ID and version
- Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan - Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration - Updated docbook-reference-plugin dependency group ID and version
|
||
private GenericApplicationContext ctx; | ||
|
||
public static void main(String[] args) throws IOException { | ||
public static void main(String[] args, String... basePackages) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't change the signature of public static void main(String[])
like that. Will need to find another way to pass those in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that mistake. I've updated to PR to revert back to a spec-compliant main method and to use a default package to scan (similar to how XML config is supported)
Closing outdated PRs and issues |
I would like to use the feature implemented in this PR. Were there any outstanding requests that weren't addressed? Could this be merged as-is? Or maybe there's an alternative way to accomplish the same thing? |
hi guys, |
@robinhowlett Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@robinhowlett Thank you for signing the Contributor License Agreement! |
Hi @raul-guerrero |