Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHL-106: Java Configuration support #66

Conversation

robinhowlett
Copy link

@robinhowlett robinhowlett commented Mar 19, 2015

  • Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan
  • Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration
  • Updated docbook-reference-plugin dependency group ID and version

- Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan
- Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration
- Updated docbook-reference-plugin dependency group ID and version

private GenericApplicationContext ctx;

public static void main(String[] args) throws IOException {
public static void main(String[] args, String... basePackages) throws IOException {
Copy link
Member

@ericbottard ericbottard May 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't change the signature of public static void main(String[]) like that. Will need to find another way to pass those in

Copy link
Author

@robinhowlett robinhowlett May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that mistake. I've updated to PR to revert back to a spec-compliant main method and to use a default package to scan (similar to how XML config is supported)

@ericbottard ericbottard self-assigned this Jul 1, 2015
@ericbottard
Copy link
Member

ericbottard commented Jun 28, 2017

Closing outdated PRs and issues

@kevinm416
Copy link

kevinm416 commented Jul 19, 2017

I would like to use the feature implemented in this PR. Were there any outstanding requests that weren't addressed? Could this be merged as-is? Or maybe there's an alternative way to accomplish the same thing?

ericbottard added a commit that referenced this issue Aug 8, 2017
@raul-guerrero
Copy link

raul-guerrero commented Jun 15, 2018

hi guys,
@ericbottard was this merged into master? will this feature be available?
Thanks!

@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jun 15, 2018

@robinhowlett Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jun 15, 2018

@robinhowlett Thank you for signing the Contributor License Agreement!

@ericbottard
Copy link
Member

ericbottard commented Jun 15, 2018

Hi @raul-guerrero
This feature was for Spring Shell 1.x
Spring Shell 2.x has out of the box @Configuration (and boot) support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants