SHL-106: Java Configuration support #66

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
5 participants
@robinhowlett
  • Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan
  • Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration
  • Updated docbook-reference-plugin dependency group ID and version
Robin Howlett
SHL-106: Java Configuration support
- Updated Bootstrap.java to accept basePackages String varargs and to include them in ClassPathBeanDefinitionScanner scan
- Updated sample HelloWorld project to demonstrate mixing XML and Java Configuration
- Updated docbook-reference-plugin dependency group ID and version
private GenericApplicationContext ctx;
- public static void main(String[] args) throws IOException {
+ public static void main(String[] args, String... basePackages) throws IOException {

This comment has been minimized.

@ericbottard

ericbottard May 13, 2015

Member

Can't change the signature of public static void main(String[]) like that. Will need to find another way to pass those in

@ericbottard

ericbottard May 13, 2015

Member

Can't change the signature of public static void main(String[]) like that. Will need to find another way to pass those in

This comment has been minimized.

@robinhowlett

robinhowlett May 14, 2015

Thanks for catching that mistake. I've updated to PR to revert back to a spec-compliant main method and to use a default package to scan (similar to how XML config is supported)

@robinhowlett

robinhowlett May 14, 2015

Thanks for catching that mistake. I've updated to PR to revert back to a spec-compliant main method and to use a default package to scan (similar to how XML config is supported)

@ericbottard ericbottard self-assigned this Jul 1, 2015

@ericbottard

This comment has been minimized.

Show comment
Hide comment
@ericbottard

ericbottard Jun 28, 2017

Member

Closing outdated PRs and issues

Member

ericbottard commented Jun 28, 2017

Closing outdated PRs and issues

@kevinm416

This comment has been minimized.

Show comment
Hide comment
@kevinm416

kevinm416 Jul 19, 2017

I would like to use the feature implemented in this PR. Were there any outstanding requests that weren't addressed? Could this be merged as-is? Or maybe there's an alternative way to accomplish the same thing?

I would like to use the feature implemented in this PR. Were there any outstanding requests that weren't addressed? Could this be merged as-is? Or maybe there's an alternative way to accomplish the same thing?

ericbottard added a commit that referenced this pull request Aug 8, 2017

@raul-guerrero

This comment has been minimized.

Show comment
Hide comment
@raul-guerrero

raul-guerrero Jun 15, 2018

hi guys,
@ericbottard was this merged into master? will this feature be available?
Thanks!

hi guys,
@ericbottard was this merged into master? will this feature be available?
Thanks!

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster Jun 15, 2018

@robinhowlett Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@robinhowlett Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@ericbottard

This comment has been minimized.

Show comment
Hide comment
@ericbottard

ericbottard Jun 15, 2018

Member

Hi @raul-guerrero
This feature was for Spring Shell 1.x
Spring Shell 2.x has out of the box @Configuration (and boot) support

Member

ericbottard commented Jun 15, 2018

Hi @raul-guerrero
This feature was for Spring Shell 1.x
Spring Shell 2.x has out of the box @Configuration (and boot) support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment